Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Replace pylint with ruff and fix linting errors #920

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

a-h-abdelsalam
Copy link
Contributor

@a-h-abdelsalam a-h-abdelsalam commented Aug 21, 2024

What

Replace pylint with ruff and fix linting errors.

Why

Make use of the default linter in python linting action and fix failing CI

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.45%. Comparing base (edb6236) to head (a1b78df).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #920   +/-   ##
=======================================
  Coverage   87.45%   87.45%           
=======================================
  Files          35       35           
  Lines        1371     1371           
=======================================
  Hits         1199     1199           
  Misses        172      172           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a-h-abdelsalam a-h-abdelsalam marked this pull request as ready for review August 22, 2024 09:34
@a-h-abdelsalam a-h-abdelsalam requested a review from a team as a code owner August 22, 2024 09:34
@a-h-abdelsalam a-h-abdelsalam changed the title Change: Replace pylint with ruff Change: Replace pylint with ruff and fix linting errors Aug 22, 2024
@a-h-abdelsalam a-h-abdelsalam merged commit 1b6904c into main Aug 23, 2024
15 checks passed
@a-h-abdelsalam a-h-abdelsalam deleted the replace-pylint-with-ruff branch August 23, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants