feat: 🔨 better help text for checkForNewRelease() #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What: in scripts/requirements.js: 1) code put inside an async function so we can await another function 2) checkForRelease() now awaited and moved to end (so its output falls at the end of the execution, just like presently in scripts/release-check.js: 1) we make checkForNewRelease an async function and switch over from promise syntax (see "releaseInfo.then()..." change) 2) introduce helper to fetch from github based on a subpath 3) add new function to get the commit of the main branch in github (this seems to fix a bug where previously "target_commitish" was "main" rather than a SHA) 4) update the logging in checkForNewRelease to use colors / icons similar to how the requirements.js works (in fact we pass in checkmark icons etc).
There was a problem hiding this comment.
Tested it locally, works fine for me. Maybe @lithrel could have some thing to add or he approves it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
in scripts/requirements.js:
at the end of the execution, just like presently
in scripts/release-check.js:
screenshots
When all is well:
If the SHA didn't match:
^ note, I hacked it to show that, hence why the SHA values actually do match in this example
AND note the blue help text: