-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVM bridge with design #164
Conversation
Deploying with Cloudflare Pages
|
4c597a7
to
659e904
Compare
Yeah, I think the values are probably fine. It's just purely the styles here, being the border, spacing, fonts, etc. It looks completely unstyled at the moment |
I thought we actually had caching somewhere in Unicove to prevent spamming the APIs, and we had some way to invalidate that 🤔 Not sure though now that you say this. It does eventually update, it just takes like 15-30 seconds or something |
My main concern was that it's just completely unstyled. The design has a specific look to it that we should make the EvmTxFollower match |
Calculating on the form field when the user clicks "Send entire balance" is probably the cleanest way to make both scenarios work 🤔 Maybe what we need is on the right side of the form, we show a status change, that then shows the total. So below the "to" field it then shows:
Then that "total transferred" field will match the entire balance, and the amount received will be accurate. However when a user inputs a specific number (1 for example), it'll show:
|
85cccf7
to
d027cd9
Compare
08f0805
to
31adcd6
Compare
5867190
to
ff12fdb
Compare
67775ef
to
79d5ff5
Compare
* chore: added evm-bridge page * chore: added link to evm-swap page * chore: added native swap page * chore: added evmToNativeTransfer section * fix: getting the /evm/swap pages working * refactor: renamed transfer functions * chore: styled the evm swap page * fix: got the native to evm swap working * fix: got the evm section working * style: linted * Removed package-lock.json and rebuilt yarn.lock * refactor: moved evm logic to separate file * fix: getting site building * enhancement: polishing swap page * enhancement: polishing of the swap page form * chore: moved select to element component * enhancement: polishing of the swap confirm page * enhancement: added EOS native balance * enhancement: added EVM EOS balance * enhancement: added basic validation * enhancement: better error handling * enhancement: polished the swap success page * enhancement: general polishing of evm bridge * style: linted * enhancement: polished the error page * enhancement: connecting to evm wallet on page load * chore: trying to connect to eth wallet automatically every 3 seconds * enhancement: general polishing of new transfer page * enhancement: making transfer confirm screen bigger * enhancement: clearing the form when changing active session * refactor: using from and to instead of transferOption * enhancement: using the token selector to let users select account * fix: getting the token selector working with evm swap form * enhancement: general polishing of evm swap form * enhancement: added selectedToken to TokenSelector * fix: only allowing form submission once both from and to tokens are selected * enhancement: making the evm swap section look decent on mobile * style: linted * enhancement: added ability to pass string instead of balance * fix: removed border on transfer confirm page * chore: using /send and /transfer as urls * fix: preventing submit if not connected to evm wallet * enhancement: displaying fee amount on confirmation page * fix: handling useEntireBalance case gracefully * style: linted * enhancement: making sure that evm provider is always accessible * enhancement: updating the balances after transfer * style: linted * enhancement: adding fee to transfer amount as opposed to removing it * chore: displaying fee and net amount in form * enhancement: styled the confirm page * enhancement: calculating fee every time an input changes * enhancement: useEntireBalance now takes into account transferFee * enhancement: displaying error when funds are insufficient to cover the transfer fee * chore: added EvmTxFollower component * enhancement: adding customization props to TxFollower components * fix: resetting the form properly when appropriate * chore: displaying usd prices on confirm page * enhancement: displaying EOS token on confirmation page * style: linted --------- Co-authored-by: Aaron Cox <[email protected]>
No description provided.