Document type conversion UX/UI #1181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexaltation
commented
Aug 27, 2024
2 tasks
hexaltation
force-pushed
the
issue-1015-convert-document-to-template-tuto
branch
from
71f3678
to
5d3449a
Compare
fflorent
reviewed
Sep 5, 2024
There was a problem hiding this comment.
Good job! This feature is promising!
Here are some comments I got.
Something that surprised me a bit is that when I:
- converted a tutorial from the Template org to a regular doc;
- made some changes;
- converted back to a tutorial;
The tutorial did not run. Any idea?
I used the Grist Basic doc for that.
hexaltation
force-pushed
the
issue-1015-convert-document-to-template-tuto
branch
from
5d3449a
to
9a21be7
Compare
fflorent
suggested changes
Oct 2, 2024
fflorent
reviewed
Oct 7, 2024
Co-authored-by: hexaltation <[email protected]> Co-authored-by: fflorent <[email protected]>
todo: tests, notification of success
fix: url deduction for page reload to apply new document type
TODO onboarding popup TODO better waiting for url change
hexaltation
force-pushed
the
issue-1015-convert-document-to-template-tuto
branch
from
92c4b15
to
6750cfd
Compare
|
The two broken tests seems not to be linked with code modified by this PR. |
fflorent
suggested changes
Oct 9, 2024
fflorent
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Document Type conversion is available through API calls and API console. As a non technical document owner I want to be able to convert my document to Template or Tutorial and vice-versa easily in the UI.
Proposed solution
This PR implements figma design by @lusebille https://www.figma.com/design/wcpetFt6aOKzTszcvPPWLQ/%5B05%2F24%5D-Grist-Design?node-id=559-80548&t=1gSxqwNd6ZsiXdFO-1
The only point not implemented is the notification after modal confirmation.
As the page needs to be reloaded its not simple to notify for the successful change.
Related issues
fixes #1015
Has this been tested?