-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header colored #581
Header colored #581
Conversation
Two problems remain :
|
Should I only add tests in the |
I believe the second one is happening because I haven't been able to reproduce the first one so far. Seems to be working ok for me? |
I'd say one test in There's already some utils in |
c7f61e3
to
e79ee9a
Compare
thanks @georgegevoian, I added tests and correct the little error I had. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening the PR @CamilleLegeron.
I left some comments and suggestions.
Co-authored-by: George Gevoian <[email protected]>
Co-authored-by: George Gevoian <[email protected]>
Co-authored-by: George Gevoian <[email protected]>
Co-authored-by: George Gevoian <[email protected]>
Co-authored-by: George Gevoian <[email protected]>
Co-authored-by: George Gevoian <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the comments.
The TypeChange test failures are unrelated so you can ignore them. (We're working on a fix.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CamilleLegeron!
Will merge once the MultiColumn tests are passing. (I think it's just the fill color that needs to be changed.)
Context
#320
Content
The style of header in GridView
We could rename the file
CellStyle.ts
byColumnStyle.ts
but it would break the translation. Or we could create anHeaderStyle.ts
new file and use the css style are in theCellStyle.ts
file.