Use new FetchSelectedOptions in onRecord/s to skip redundant fetch #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aise more helpful error when using a callback without linking widgets.
alexmojaki
added a commit
to gristlabs/grist-widget
that referenced
this pull request
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a performance optimization which may or may not be significant, so it's not particularly important, it's just an itch I wanted to scratch. It make use of the new options in gristlabs/grist-core@4e67c67. Before this, when triggering the
on_recordscallback, the initial payload of records (which had been painstakingly transposed and decoded) was immediately discarded in favour offetch_selected_tablewhich had thekeepEncodedoption. The behaviour should be unchanged.Along the way I ran into a confusing error about NoneType not being subscriptable, and had to dig deep to see that it was because I'd forgotten to link the notebook to another widget. Now a more helpful error is raised.