Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warnings issue #1 [Textpow 1.3.1] warning on bad unicode syntax #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Utopism
Copy link

@Utopism Utopism commented Jul 16, 2014

Hi, can you check this pull request ?

modifié:         lib/textpow/syntax.rb
modifié:         lib/textpow/syntax/source.camlp4.ocaml.syntax
modifié:         lib/textpow/syntax/source.ocaml.syntax
modifié:         lib/textpow/syntax/text.bbcode.syntax
modifié:         lib/textpow/syntax/text.html.asp.net.syntax
modifié:         lib/textpow/syntax/text.html.mt.syntax
modifié:         lib/textpow/syntax/text.html.strict.active4d.syntax
modifié:         lib/textpow/syntax/text.html.tt.syntax
modifié:         lib/textpow/syntax/text.html.twiki.syntax
modifié:         lib/textpow/syntax/text.html.xhtml.1-strict.syntax
modifié:         lib/textpow/syntax/text.restructuredtext.syntax
modifié:         lib/textpow/syntax/text.tex.latex.sweave.syntax

	modifié:         lib/textpow/syntax.rb
	modifié:         lib/textpow/syntax/source.camlp4.ocaml.syntax
	modifié:         lib/textpow/syntax/source.ocaml.syntax
	modifié:         lib/textpow/syntax/text.bbcode.syntax
	modifié:         lib/textpow/syntax/text.html.asp.net.syntax
	modifié:         lib/textpow/syntax/text.html.mt.syntax
	modifié:         lib/textpow/syntax/text.html.strict.active4d.syntax
	modifié:         lib/textpow/syntax/text.html.tt.syntax
	modifié:         lib/textpow/syntax/text.html.twiki.syntax
	modifié:         lib/textpow/syntax/text.html.xhtml.1-strict.syntax
	modifié:         lib/textpow/syntax/text.restructuredtext.syntax
	modifié:         lib/textpow/syntax/text.tex.latex.sweave.syntax
Reference to Redmine added
	modifié:         README.rdoc
* The Ultraviolet gem is used by the Redmine_ultraviolet plugin
https://github.com/jbbarth/redmine_ultraviolet

With Redmine, Textpow warnings still exist when Rails is launched :
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if we need these warnings in details :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, especially if we fix them :-)

@grosser
Copy link
Owner

grosser commented Jul 16, 2014

travis is not happy with the /n match, are you using it on 1.8 ?

@grosser
Copy link
Owner

grosser commented Jul 19, 2014

travis is spitting out tons of warnings and fails, so not sure what the issue is, maybe just do the regex changes to reduce warnings ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants