Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental support for creating multi-class detectors #261

Merged
merged 9 commits into from
Oct 10, 2024

Conversation

tyler-romero
Copy link
Member

@tyler-romero tyler-romero commented Oct 7, 2024

Fix the format for creating a multi-class detector w/ class_names, and add a function to the experimental part of the sdk to explicitly support this.

@tyler-romero tyler-romero force-pushed the tyler/multiclass-detector-support branch from 63601cc to bb9fa6e Compare October 9, 2024 22:16
@tyler-romero tyler-romero marked this pull request as ready for review October 9, 2024 22:19
Copy link
Collaborator

@brandon-groundlight brandon-groundlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, sans one nit and your second PR to enable the tester

name, "What kind of dog is this?", class_names=class_names
)
assert created_detector is not None
count_iq = gl_experimental.submit_image_query(created_detector, "test/assets/dog.jpeg")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, it's not a count_iq

@tyler-romero tyler-romero merged commit 126f308 into main Oct 10, 2024
8 checks passed
@tyler-romero tyler-romero deleted the tyler/multiclass-detector-support branch October 10, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants