Switch Human Review Query Parameter from Boolean to String #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjvogelsong
reviewed
Aug 10, 2023
mjvogelsong
reviewed
Aug 10, 2023
#84) * updated wait times on tests such that they can pass server size validation. This will be improved once we separate client and service wait times * Automatically reformatting code * small update based on Tim's review * Automatically reformatting code --------- Co-authored-by: Auto-format Bot <[email protected]>
mjvogelsong
approved these changes
Aug 10, 2023
Co-authored-by: Michael Vogelsong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
human_reviewquery parameter such that it is passed in as a string instead of a boolean variable. The choices forhuman_reviewincludeDEFAULT,ALWAYS, andNEVER.It also ensures that the patience time that is sent to the server-side code is at least 10.
Test cases are expected to pass once this change is reflected in the server code.