Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use module version of googleapis #153

Merged
merged 3 commits into from
Jun 27, 2024
Merged

use module version of googleapis #153

merged 3 commits into from
Jun 27, 2024

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Jun 17, 2024 •
edited
Loading

Notice that the bazel_dep of googleapis is incompatible with bazel 6.

@mmorel-35 mmorel-35 mentioned this pull request Jun 17, 2024
Merged
keith
keith reviewed Jun 17, 2024
View reviewed changes
MODULE.bazel Outdated Show resolved Hide resolved
ejona86
ejona86 approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given bzlmod users likely want Bazel 7, not supporting Bazel 6 for them seems acceptable. It's not like we've been supporting bzlmod for a long time in this repo. Looks like grpc and grpc-java repos already require Bazel 7 for bzlmod.

@ejona86 ejona86 requested a review from veblush June 17, 2024 22:52
keith
keith reviewed Jun 20, 2024
View reviewed changes
MODULE.bazel Outdated Show resolved Hide resolved
@mmorel-35
Copy link
Contributor Author

@veblush

When will you be able to review this, please ?

@ejona86 ejona86 merged commit ec30f58 into grpc:master Jun 27, 2024
4 checks passed
@mmorel-35 mmorel-35 deleted the bcr branch June 27, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keith keith keith approved these changes

@veblush veblush veblush approved these changes

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmorel-35 @keith @veblush @ejona86