Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bazel targets for s2a proto files #156

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

pkwarren
Copy link
Contributor

@pkwarren pkwarren commented Jul 5, 2024

Update the bazel build to add targets for the s2a proto files. Fix syntax error in s2a_context.proto.

Fixes #155.

Update the bazel build to add targets for the s2a proto files. Fix
syntax error in s2a_context.proto.

Fixes grpc#155.
BUILD.bazel Show resolved Hide resolved
@ejona86
Copy link
Member

ejona86 commented Jul 8, 2024

CC @rmehta19

Copy link
Contributor

@matthewstevenson88 matthewstevenson88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ejona86!

@ejona86 ejona86 merged commit 720fb1a into grpc:master Jul 8, 2024
4 checks passed
@ejona86
Copy link
Member

ejona86 commented Jul 8, 2024

Thanks @pkwarren. This will be the last time!

@pkwarren pkwarren deleted the pkw/issue-155 branch July 8, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to compile s2a_context.proto
3 participants