Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile with miniupnpc 2.2.8 fails #458

Open
heitbaum opened this issue Jul 5, 2024 · 0 comments · May be fixed by #459
Open

Compile with miniupnpc 2.2.8 fails #458

heitbaum opened this issue Jul 5, 2024 · 0 comments · May be fixed by #459

Comments

@heitbaum
Copy link

heitbaum commented Jul 5, 2024

Compile with 2.2.7 works
Ref from miniupnpc:

[82/93] Compiling C object src/libtincd.a.p/upnp.c.o
FAILED: src/libtincd.a.p/upnp.c.o 
/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/bin/x86_64-libreelec-linux-gnu-gcc -Isrc/libtincd.a.p -Isrc/include -I../src/include -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include/lzo -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Wpedantic -std=c11 -Wbad-function-cast -Wduplicated-branches -Wduplicated-cond -Wformat-overflow=2 -Wformat-truncation=1 -Wformat=2 -Wlogical-op -Wmissing-declarations -Wmissing-noreturn -Wmissing-prototypes -Wold-style-definition -Wredundant-decls -Wreturn-type -Wstrict-prototypes -Wswitch-enum -Wtrampolines -Wvla -Wwrite-strings -fdiagnostics-show-option -fno-strict-overflow -fstrict-aliasing -fcf-protection=full -fstack-protector-strong -fstack-clash-protection -march=x86-64-v3 -Wall -pipe -O2 -fomit-frame-pointer -DNDEBUG -fPIC -DPIC -fPIC -pthread -D_GNU_SOURCE -Wbad-function-cast -Wduplicated-branches -Wduplicated-cond -Wformat-overflow=2 -Wformat-truncation=1 -Wformat=2 -Wlogical-op -Wmissing-declarations -Wmissing-noreturn -Wmissing-prototypes -Wold-style-definition -Wredundant-decls -Wreturn-type -Wstrict-prototypes -Wswitch-enum -Wtrampolines -Wvla -Wwrite-strings -fdiagnostics-show-option -fno-strict-overflow -fstrict-aliasing -D_FORTIFY_SOURCE=2 -fcf-protection=full -fstack-protector-strong -fstack-clash-protection -MD -MQ src/libtincd.a.p/upnp.c.o -MF src/libtincd.a.p/upnp.c.o.d -o src/libtincd.a.p/upnp.c.o -c ../src/upnp.c
../src/upnp.c: In function 'upnp_discover':
../src/upnp.c:65:2: warning: #warning before C23 is a GCC extension
   65 | #warning "The version of libminiupnpc you're building against seems to be too recent. Expect trouble."
      |  ^~~~~~~
../src/upnp.c:65:2: warning: #warning "The version of libminiupnpc you're building against seems to be too recent. Expect trouble." [-Wcpp]
../src/upnp.c: In function 'upnp_refresh':
../src/upnp.c:126:22: error: too few arguments to function 'UPNP_GetValidIGD'
  126 |         int result = UPNP_GetValidIGD(devices, &urls, &data, myaddr, sizeof(myaddr));
      |                      ^~~~~~~~~~~~~~~~
In file included from ../src/upnp.c:24:
/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include/miniupnpc/miniupnpc.h:122:1: note: declared here
  122 | UPNP_GetValidIGD(struct UPNPDev * devlist,
      | ^~~~~~~~~~~~~~~~
dlan17 added a commit to dlan17/tinc that referenced this issue Jul 8, 2024
adjust once update to miniupnpc-2.2.8

Closes: gsliepen#458
Signed-off-by: Yixun Lan <[email protected]>
@dlan17 dlan17 linked a pull request Jul 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant