Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upnp: fix API change issue #459

Open
wants to merge 1 commit into
base: 1.1
Choose a base branch
from
Open

upnp: fix API change issue #459

wants to merge 1 commit into from
+5 −1

Conversation

dlan17
Copy link

@dlan17 dlan17 commented Jul 8, 2024

adjust once update to miniupnpc-2.2.8

Closes: #458

@dlan17
upnp: fix API change issue
8331467 
adjust once update to miniupnpc-2.2.8

Closes: gsliepen#458
Signed-off-by: Yixun Lan <[email protected]>
@heitbaum
Copy link

Compiles successfully now. But there is still a warning.

[91/93] Compiling C object src/libtincd.a.p/upnp.c.o
../src/upnp.c: In function 'upnp_discover':
../src/upnp.c:65:2: warning: #warning before C23 is a GCC extension
   65 | #warning "The version of libminiupnpc you're building against seems to be too recent. Expect trouble."
      |  ^~~~~~~
../src/upnp.c:65:2: warning: #warning "The version of libminiupnpc you're building against seems to be too recent. Expect trouble." [-Wcpp]

@fangfufu
Copy link
Collaborator

@gsliepen , you approved these changes, do you want them to be merged or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsliepen gsliepen gsliepen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compile with miniupnpc 2.2.8 fails
4 participants
@dlan17 @heitbaum @fangfufu @gsliepen