Skip to content

Commit

Permalink
mmc: meson-gx: remove useless lock
Browse files Browse the repository at this point in the history
[ Upstream commit 83076d2268c72d123f3d1eaf186a9f56ec1b943a ]

The spinlock is only used within the irq handler so it does not
seem very useful.

Signed-off-by: Jerome Brunet <[email protected]>
Signed-off-by: Ulf Hansson <[email protected]>
Stable-dep-of: 3c40eb814532 ("mmc: meson-gx: remove redundant mmc_request_done() call from irq context")
Signed-off-by: Sasha Levin <[email protected]>
Signed-off-by: Harshit Mogalapalli <[email protected]>
  • Loading branch information
jbrun3t authored and harshimogalapalli committed May 6, 2024
1 parent 1685325 commit d27937e
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions drivers/mmc/host/meson-gx-mmc.c
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
#include <linux/of_device.h>
#include <linux/platform_device.h>
#include <linux/ioport.h>
#include <linux/spinlock.h>
#include <linux/dma-mapping.h>
#include <linux/mmc/host.h>
#include <linux/mmc/mmc.h>
Expand Down Expand Up @@ -136,7 +135,6 @@ struct meson_host {
struct mmc_host *mmc;
struct mmc_command *cmd;

spinlock_t lock;
void __iomem *regs;
struct clk *core_clk;
struct clk *mmc_clk;
Expand Down Expand Up @@ -1016,8 +1014,6 @@ static irqreturn_t meson_mmc_irq(int irq, void *dev_id)
if (WARN_ON(!host) || WARN_ON(!host->cmd))
return IRQ_NONE;

spin_lock(&host->lock);

cmd = host->cmd;
data = cmd->data;
cmd->error = 0;
Expand Down Expand Up @@ -1067,7 +1063,6 @@ static irqreturn_t meson_mmc_irq(int irq, void *dev_id)
if (ret == IRQ_HANDLED)
meson_mmc_request_done(host->mmc, cmd->mrq);

spin_unlock(&host->lock);
return ret;
}

Expand Down Expand Up @@ -1220,8 +1215,6 @@ static int meson_mmc_probe(struct platform_device *pdev)
host->dev = &pdev->dev;
dev_set_drvdata(&pdev->dev, host);

spin_lock_init(&host->lock);

/* Get regulators and the supported OCR mask */
host->vqmmc_enabled = false;
ret = mmc_regulator_get_supply(mmc);
Expand Down

0 comments on commit d27937e

Please sign in to comment.