Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More compatibility updates #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

pwm1234
Copy link

@pwm1234 pwm1234 commented Feb 28, 2019

Thanks for fixing the problems with 1.y.z. Your changes were much better than mine!

In this PR I added a config setting for the rotate_on_open argument to the spdlog rotating file sink constructor with commit gabime/spdlog@2463fe9
I also updated the version check in CMakeLists.txt from 0.14.0 to 1.0.0.

Finally I added a call to spdlog::set_pattern if global_pattern was set. (This is not really a compatibility change, but I think it is more correct to have this logic in that to leave it out.)

Thanks again for your help!

@pwm1234
Copy link
Author

pwm1234 commented Feb 28, 2019

Sorry, I believe this PR is premature. It is based on a spdlog commit that was after that most recent 1.3.1 spdlog release. I can either add a version check to it, or we can just wait until 1.3.2 is out.

@guangie88
Copy link
Owner

Thanks for the PR, this would be good to be put into the repo once spdlog v1.3.2 includes it in, but I might be concern about the backward compatibility with <= v1.3.1 since this breaks the function call. It would most likely have to be wrapped in macro to cater to both sides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants