Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for fixing the problems with 1.y.z. Your changes were much better than mine!
In this PR I added a config setting for the rotate_on_open argument to the spdlog rotating file sink constructor with commit gabime/spdlog@2463fe9
I also updated the version check in CMakeLists.txt from 0.14.0 to 1.0.0.
Finally I added a call to spdlog::set_pattern if global_pattern was set. (This is not really a compatibility change, but I think it is more correct to have this logic in that to leave it out.)
Thanks again for your help!