Add dist sink support #69
Open
+254
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Itay Bookstein <[email protected]>
Signed-off-by: Itay Bookstein <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
+ Coverage 88.16% 88.35% +0.19%
==========================================
Files 4 4
Lines 566 601 +35
==========================================
+ Hits 499 531 +32
- Misses 67 70 +3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again!
I implemented support for dist sinks (including verification that no circular references are made), and we're already using them. Was wondering whether you'd be interested. I saw that they were documented as 'not part of the use case', but I figured they might be useful for others some time or other, for grouping/aggregation within the configuration file :)
I'm a bit dissatisfied with the two dynamic casts, but alas, there is no common base class for both template instantiations that would allow me to call the relevant API, and I didn't want to propagate 'redundant' information through parameters.