Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove QuoteIcon #1730

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Remove QuoteIcon #1730

merged 4 commits into from
Oct 10, 2024

Conversation

SiAdcock
Copy link
Contributor

@SiAdcock SiAdcock commented Oct 9, 2024

What are you changing?

  • Remove the QuoteIcon component, related tests and stories, and the HeadlineSize type
  • Extra bit: Fix the Logo README title, which was previously mistakenly "QuoteIcon"

Why?

@SiAdcock SiAdcock requested review from a team as code owners October 9, 2024 09:27
Copy link

changeset-bot bot commented Oct 9, 2024

🦋 Changeset detected

Latest commit: 4b0acdf

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@SiAdcock SiAdcock merged commit 097cb9d into main Oct 10, 2024
19 checks passed
@SiAdcock SiAdcock deleted the sa-remove-quote-icon branch October 10, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants