Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove EditorialButton and EditorialLinkButton components #1731

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Remove EditorialButton and EditorialLinkButton components #1731

merged 4 commits into from
Oct 10, 2024

Conversation

SiAdcock
Copy link
Contributor

@SiAdcock SiAdcock commented Oct 9, 2024

What are you changing?

  • Remove the EditorialButton and EditorialLinkButton component, related tests and stories

Why?

@SiAdcock SiAdcock requested review from a team as code owners October 9, 2024 10:54
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 667454b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Oct 9, 2024
@SiAdcock SiAdcock requested review from a team as code owners October 9, 2024 10:56
@SiAdcock SiAdcock mentioned this pull request Oct 9, 2024
Closed
@SiAdcock SiAdcock added the run_chromatic Runs chromatic when label is applied label Oct 9, 2024
domlander
domlander approved these changes Oct 10, 2024
View reviewed changes
Copy link

@domlander domlander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@SiAdcock SiAdcock merged commit 02018b3 into main Oct 10, 2024
19 checks passed
@SiAdcock SiAdcock deleted the sa-remove-editorial-button branch October 10, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sndrs sndrs sndrs approved these changes

@domlander domlander domlander approved these changes

Assignees
No one assigned
Labels
📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SiAdcock @sndrs @domlander