US Expandable Marketing Card component on small screens #12534
Merged
+324
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +998 B (+0.11%) Total Size: 905 kB
ℹ️ View Unchanged
|
domlander
force-pushed
the
doml/guardian-different-mobile
branch
6 times, most recently
from
4591d1f
to
4e1037e
Compare
github-actions
bot
removed
the
run_chromatic
domlander
commented
Oct 15, 2024
| @@ -573,22 +572,6 @@ export const PictureLayout = (props: WebProps | AppsProps) => { | |||
| /> | |||
| </ArticleContainer> | |||
| </GridItem> | |||
| {isWeb && ( | |||
There was a problem hiding this comment.
Picture Layouts aren't well suited to showing this component. We can leave out pages with the Picture Layout from the AB test and still hit sample sizes
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
domlander
changed the title
|
|
||
| @keyframes slidein { | ||
| from { | ||
| translate: -1200px 0; |
There was a problem hiding this comment.
Suggested change
| translate: -1200px 0; | |
| transform: translate: (-1200px, 0) |
Should these be something like this. https://developer.mozilla.org/en-US/docs/Web/CSS/transform-function/translate
domlander
force-pushed
the
doml/guardian-different-mobile
branch
from
3eea191
to
f5e3d90
Compare
github-actions
bot
removed
the
run_chromatic
|
Seen on PROD (merged by @domlander 7 minutes and 49 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Displays the US Expandable Marketing component on small screens. This builds on the work to display this component on large screens: #12530.
The component is animated in from the left when the users scrolls past the top of the body.
Why?
So that we can test the effectiveness of this component for US users.
This will only be shown to users if they meet all of the following conditions:
Screenshots
Screen shares
Screen.Recording.2024-10-11.at.16.21.26.mov
Screen.Recording.2024-10-11.at.16.20.15.mov