Add podcast meta to the audio page #12552
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2f40922.
|
Size Change: +44 B (0%) Total Size: 904 kB ℹ️ View Unchanged
|
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
github-actions
bot
removed
the
run_chromatic
# Conflicts: # dotcom-rendering/src/layouts/StandardLayout.tsx
github-actions
bot
removed
the
run_chromatic
SiAdcock
reviewed
Oct 18, 2024
| audioDownloadUrl={audioDownloadUrl} | ||
| rssFeedUrl={rssFeedUrl} | ||
| /> | ||
| )} |
There was a problem hiding this comment.
I wish there was a better way of doing this, rather than having all this audio-specific logic defined in the top ArticleMeta component. Unhelpful that I can't think of anything better 😅
There was a problem hiding this comment.
This will be refactored out when we create the audioLayout layout It just works for now where we are using standard Layout
SiAdcock
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Creates a new
PodcastMetacomponent.This renders the podcast data provided in: guardian/frontend#27477 , guardian/frontend#27501
Why?
We're migrating the audio page from frontend to dcr
renewed version of this reverted PR -> #12357
Screenshots