-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a restoreFromReplica
endpoint to image-loader
#4128
Conversation
445ca43
to
d25e3a1
Compare
…l if we restore from replica)
…ageId` a form field in payload) to restore image from replica bucket (wired into a new view in thrall)
d25e3a1
to
7e18a96
Compare
7e18a96
to
8712bec
Compare
Co-authored-by: Andrew Nowak <[email protected]>
demoed/tested with @andrew-nowak in |
Seen on metadata-editor, cropper, usage (merged by @twrichards 9 minutes and 49 seconds ago) Please check your changes! |
Seen on auth, image-loader, media-api (merged by @twrichards 9 minutes and 55 seconds ago) Please check your changes! |
Seen on thrall, kahuna (merged by @twrichards 10 minutes and 6 seconds ago) Please check your changes! |
Seen on collections, kahuna (merged by @twrichards 10 minutes and 6 seconds ago) Please check your changes! |
Seen on thrall, kahuna (merged by @twrichards 10 minutes and 6 seconds ago) Please check your changes! |
Seen on leases (merged by @twrichards 10 minutes and 10 seconds ago) Please check your changes! |
1 similar comment
Seen on leases (merged by @twrichards 10 minutes and 10 seconds ago) Please check your changes! |
REQUIRES #4130
https://trello.com/c/ffAUNID4/1621-lazarus-mechanism-to-restore-deleted-grid-images-from-replica-bucket
Related #4125 (closed, since unlike this PR it didn't reinstate the image file in the image bucket, nor did it recreate thumbs or optimised image, which will have been deleted during reaping).
Following on from the excellent #4116. Adds a similar looking mechanism, but to reload the file from the 'replica bucket' (see https://github.com/guardian/editorial-tools-platform/pull/696 for more about replica buckets). It then layers on top user edits etc. from Dynamo (thanks to #4130).
The approach in this PR preserves the original
uploadTime
,uploadedBy
and original filename.This should help us restore images quickly which have been hard deleted by mistake (perhaps by reaper) - so long as we have the ID of course.
Requires new (optional) bit of image loader config
s3.image.replicaBucket
. Added in...TEST
PROD