Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t1836: Fixing "Cannot download" button padding #4327

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shannonmcgurk
Copy link

@shannonmcgurk shannonmcgurk commented Sep 10, 2024

What does this change?

This PR addresses an inconsistency in padding between the "Download" and "Cannot Download" buttons. Previously, the "Cannot Download" button lacked proper padding compared to the "Download" button. To resolve this, I have created a specific CSS rule for class corresponding to the "Cannot Download" button, ensuring that it now has consistent padding.

Before:
Screenshot 2024-09-11 at 17 11 31
Screenshot 2024-09-11 at 17 10 39

After:
Screenshot 2024-09-11 at 18 18 19

How should a reviewer test this change?

Verify that the "Download" button and the "Cannot Download" button have consistent padding when selecting an image with public rights and an image with no rights.

How can success be measured?

Ensuring that the padding for the "Cannot Download" button is visually consistent with the "Download" button across all scenarios.

Who should look at this?

Tested? Documented?

  • locally by committer
  • locally by Guardian reviewer
  • on the Guardian's TEST environment
  • relevant documentation added or amended (if needed)

@shannonmcgurk shannonmcgurk marked this pull request as ready for review September 11, 2024 17:24
@shannonmcgurk shannonmcgurk requested review from a team as code owners September 11, 2024 17:24
@shannonmcgurk shannonmcgurk changed the title Fixing cannot download padding t1836: Fixing "Cannot download" button padding Sep 11, 2024
Copy link
Contributor

@Conalb97 Conalb97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

class="download-icon-label"
gr-tooltip="Downloading non-free images requires a lease"
>
class="cannot-download-icon-label"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works, but did you consider using the side-padded class that the other buttons use to add padding? it would mean one less CSS rule to maintain for just this version of the button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants