add a shouldShowCropGuttersIfApplicable query param
#4343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twrichards
force-pushed
the
only-display-crop-gutters-via-url-param
branch
from
e91ec84
to
ddf479c
Compare
twrichards
changed the title
shouldShowCropGuttersIfApplicable query paramshouldShowCropGuttersIfApplicable query param
twrichards
force-pushed
the
only-display-crop-gutters-via-url-param
branch
from
ddf479c
to
ef6216c
Compare
…rop gutters if `true` (and other conditions for showing the gutters)
twrichards
force-pushed
the
only-display-crop-gutters-via-url-param
branch
from
ef6216c
to
2ac4d87
Compare
bryophyta
approved these changes
Oct 7, 2024
twrichards
added a commit
that referenced
this pull request
Oct 7, 2024
…GNM users see the cropping gutters when cropping 5:3 which is now limited to only certain scenarios by query param `shouldShowCropGuttersIfApplicable` (thanks to #4343)
twrichards
added a commit
that referenced
this pull request
Oct 7, 2024
…GNM users see the cropping gutters when cropping 5:3 which is now limited to only certain scenarios by query param `shouldShowCropGuttersIfApplicable` (thanks to #4343)
andrew-nowak
approved these changes
Oct 8, 2024
prout-bot
added
Pending-on-cropper
Pending-on-leases
Pending-on-media-api
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
Pending-on-thrall
Seen-on-image-loader
Seen-on-collections
and removed
Pending-on-image-loader
Pending-on-collections
labels
|
Seen on collections, image-loader (merged by @twrichards 8 minutes and 39 seconds ago) Please check your changes! |
prout-bot
added
Seen-on-kahuna
Seen-on-thrall
and removed
Pending-on-kahuna
Pending-on-thrall
labels
|
Seen on thrall, kahuna (merged by @twrichards 8 minutes and 44 seconds ago) Please check your changes! |
|
Seen on auth, leases, usage (merged by @twrichards 8 minutes and 48 seconds ago) Please check your changes! |
|
Seen on metadata-editor, cropper, media-api (merged by @twrichards 8 minutes and 53 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and only show crop gutters* if
true(plus the existing conditions for showing the gutters).This will be used by https://github.com/guardian/flexible-content/pull/4974
*the crop gutters were introduced in #4331