upgrade to scanamo v2.0.0 latest #4349
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-nowak
commented
Oct 8, 2024
Comment on lines
-24
to
-26
| private def extractUnprocessedIds(results: List[BatchWriteItemResult]): List[String] = | ||
| results.flatMap(_.getUnprocessedItems.values().asScala.flatMap(_.asScala.map(_.getPutRequest.getItem.get("id").getS))) | ||
|
|
There was a problem hiding this comment.
scanamo no longer returns the list of unprocessed items; it looks like it internally will repeat until all items have been processed, so we should no longer have to care about it in our application code?!
https://github.com/scanamo/scanamo/blob/3a68697525c8dde1e1aee757d2d1f729511106b7/scanamo/src/main/scala/org/scanamo/ScanamoFree.scala#L56-L64
andrew-nowak
force-pushed
the
an/scanamo-2
branch
from
f2a75f4
to
f5d75c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Upgrades scanamo to v2.0.0
First component switched to AWS SDK v2
How should a reviewer test this change?
How can success be measured?
Who should look at this?
Tested? Documented?