LeakCanary investigation to find memory leaks #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- destroy() releases the camera resource unlike close() which just stops the preview Signed-off-by: Arka Prava Basu <[email protected]>
- setting LifecycleOwner will remove boilerplate around open(), close() and destroy() - a possible fix for guardianproject#376 ? Signed-off-by: Arka Prava Basu <[email protected]>
- holding this reference may lead to Context leak Signed-off-by: Arka Prava Basu <[email protected]>
Signed-off-by: Arka Prava Basu <[email protected]>
- keeping Context (Activity/Fragment) in a singleton will cause memory leaks Keep the global application object associated with it instead - fix guardianproject#399 Signed-off-by: Arka Prava Basu <[email protected]>
Signed-off-by: Arka Prava Basu <[email protected]>
- Among others this updates materialdatetimepicker to 4.2.0 which fixes a memory leak Signed-off-by: Arka Prava Basu <[email protected]>
- keep this app dependency free; can be added in debug builds whenever another investigation is required Signed-off-by: Arka Prava Basu <[email protected]>
archie94
changed the title
|
Some major leaks around Camera, Settings, Signal and MaterialDateTime Picker fixed. Please test once and consider merging. |
|
Merged fine, and is not crashing, but seem to not be capturing all the camera positive detect events. Will dig and test some more. |
|
Definitely something different happening with logging events. Master works fine, but this PR seems to not be persisting matched events. |
|
:/ I hope these event / event triggers are solely around the camera? Thanks for the testing! |
…anary Signed-off-by: Arka Prava Basu <[email protected]>
Signed-off-by: Arka Prava Basu <[email protected]>
Signed-off-by: Arka Prava Basu <[email protected]>
- aims to solve guardianproject#395 (comment) - According to https://developer.android.com/reference/androidx/lifecycle/DefaultLifecycleObserver [DefaultLifecycleObserver] should *always* be preferred over [androidx.lifecycle.LifecycleObserver] if we use Java 8. [CameraView] library targets Java 7 hence this implementation aims to ignore [androidx.lifecycle.OnLifecycleEvent] annotated methods in the super class and replace them with the callbacks implemeted in this sub class Signed-off-by: Arka Prava Basu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call cameraview destroy() instead of close() on Fragment onDestroy()Do the same withLifecycleOwner-> #393