Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(header): 🚀💣 add new prop to become header fluid or contained #594

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Dario-Felipe
Copy link
Contributor

Description 📄

Dear devs 👋🏽,

I noticed that the Header component has only one behavior, which is to occupy all available space on the page.

So I saw the opportunity to improve it by making it accept a fluid prop to keep the current behavior, and by default follow the current yoga container.

This PR is referred to as breaking change because it changes the default behavior to contained and if it needs to be fluid at the time of use, it must be passed as a prop.

Finally, with these changes it was necessary to insert a new variant of the header in its documentation and also to update the snapshot test.

Platforms 📲

  • Web
  • Mobile

Type of change 🔍

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? 🧪

[Enter the tips to test this PR]

  • Unit Test
  • Snapshot Test

Checklist: 🔍

  • My code follows the contribution guide of this project Contributing Guide
  • Layout matches design prototype: FIGMA
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Screenshots 📸

Before After
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants