feat(header): 🚀💣 add new prop to become header fluid or contained #594
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📄
Dear devs 👋🏽,
I noticed that the Header component has only one behavior, which is to occupy all available space on the page.
So I saw the opportunity to improve it by making it accept a
fluid
prop to keep the current behavior, and by default follow the current yoga container.This PR is referred to as
breaking change
because it changes the default behavior tocontained
and if it needs to befluid
at the time of use, it must be passed as a prop.Finally, with these changes it was necessary to insert a new variant of the header in its documentation and also to update the snapshot test.
Platforms 📲
Type of change 🔍
How Has This Been Tested? 🧪
[Enter the tips to test this PR]
Checklist: 🔍
Screenshots 📸