chore: improve popover accessibility implementation #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add zIndex property with default to 1, so multiple popover don't overflow. - include overflow: auto on container so user can scroll if content overflows. - include a11yId so content is better described for accessibility users. - add popover toggle behaviour on enter if the user is using the keyboard to navigate and include basic focus style so user knows where he is while doing so.
MicaelRodrigues
requested review from
caiotracera,
matheushdsbr,
rafaelcoletagympass,
goncalo-matos and
ericcleao
MicaelRodrigues
commented
Jul 12, 2023
| title: undefined, | ||
| position: 'bottom-center', | ||
| width: 265, | ||
| height: 116, | ||
| height: 200, |
There was a problem hiding this comment.
I've updated this value to allow "text" content to grow at least until 200px which seems more reasonable (max-height). Please let me know if there is defined "rule"
Comment on lines
+106
to
+107
| box-shadow: ${elevations.small}; | ||
| transition: box-shadow ease 0.5s; |
There was a problem hiding this comment.
I use our elevation box shadow, so a user navigating with keyboard can have a sense on the element being focused.
MicaelRodrigues
changed the title
ericcleao
approved these changes
Jul 12, 2023
matheushdsbr
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces some improvements to
Popoverimplementation:Description 📄
[Enter the description of your changes]
Platforms 📲
Type of change 🔍
How Has This Been Tested? 🧪
[Enter the tips to test this PR]
Checklist: 🔍
Screenshots 📸
ZIndex
Overflow: auto
Enter key + focus
Screen.Recording.2023-07-12.at.17.29.00.mov
[Upload your screenshots here]