feat: Issue #2369 Regarding Fuzzy Search #2437
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test cases for using exact (instead of fuzzy search)
Edited the interface to allow exactsearch
Added a function for searching with exact terms of top of the fuzzysearch
|
Why did you close the PR @wel013? It looks good at the first sight, just need to get some time to go through it thorougly. |
|
Hi, I believe I closed this possibly due to an accidental mistake on my end, sorry about it! |
mturoci
requested changes
Dec 12, 2024
Comment on lines
+64
to
+65
| /**Whether the search will be exact or fuzzy */ | ||
| exactSearch?: B |
There was a problem hiding this comment.
Suggested change
| /**Whether the search will be exact or fuzzy */ | |
| exactSearch?: B | |
| /** Whether the dropdown search will be exact or fuzzy. Defaults to True. */ | |
| fuzzy_search?: B |
Comment on lines
+27
to
+32
| // parts / utils.ts | ||
| export const exactsearch = (searchTerm: string, itemText: string): boolean => { | ||
|
|
||
| // Convert both strings to lowercase for case-insensitive comparison | ||
| return itemText.toLowerCase() === searchTerm.toLowerCase(); // Exact match | ||
| }; |
There was a problem hiding this comment.
No need for a separate function since it's so simple, can be inlined.
Comment on lines
+183
to
+184
| ? exactsearch(i.text, newVal) // Assuming exactsearch is a function for exact matching | ||
| : fuzzysearch(i.text, newVal), // Assuming fuzzysearch is a function for fuzzy matching |
There was a problem hiding this comment.
No need for extra comments.
Suggested change
| ? exactsearch(i.text, newVal) // Assuming exactsearch is a function for exact matching | |
| : fuzzysearch(i.text, newVal), // Assuming fuzzysearch is a function for fuzzy matching | |
| ? exactsearch(i.text, newVal) | |
| : fuzzysearch(i.text, newVal), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fulfills these requirements: (check all the apply)
mainbranch.feat: Add a button #xxx, where "xxx" is the issue number).Closes #xxx, where "xxx" is the issue number.uifolder, unit tests (make test) still pass.This is regarding the issue of someone suggested to be able to "toggle" the fuzzy search for dropdowns and allow for exact search. The main change was one more boolean attribute for the interface in dropdown.