Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix showing progress in solution mode #72

Closed
wants to merge 1 commit into from

Conversation

otacke
Copy link
Contributor

@otacke otacke commented Feb 5, 2021

When merged in, the changes fix the outer right progress dot not bearing the answered state when switching to solution mode. See report at #71

@fnoks
Copy link
Contributor

fnoks commented Aug 17, 2022

I believe this is more of a symptom fix. I.e: The issue is that the progress dot is not updated when xAPI answered is triggered. This is the reason:

if ($el.hasClass('current')) {

For me this seems like a bug - I don't see any reason why the current question's dot shouldn't be updated. Only removing this check won't work, though, since the aria label then won't include "current". For me it seems toggleAnsweredDot and toggleCurrentDot should be merged together.

@fnoks fnoks closed this Aug 17, 2022
@otacke otacke deleted the fix-progress-dot branch August 22, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants