HFP-4037 Fix sanitization of visual parameters #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otacke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged in, will fix setting the default value for
visuals.disableFullscreenduring sanitization.The idea of the current code is to allow the video to be sent to full screen by default (21b6d04). However, jQuery's
extendfunction will overwrite thedisableFullscreenwithfalse(3rd argument) in any case - even if it is set totruein the target parameter (2nd argument). That means that setting the parameter (by a parent content type) has no effect.Fixed by reversing the order of the 2nd and the 3rd argument of
extend, sodisableFullscreen: falseis set by default, but will be overridden if the content parameters supply a value fordisableFullscreen.