-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nanoo.tv video support #51
base: master
Are you sure you want to change the base?
Conversation
I am working at Werft22, the company behind nanoo.tv. We are willing to continue supporting this integration, as many of our customers want to use nanoo.tv videos with H5P's "interactive video" feature. |
In case of a login redirect the squash overlay prevents the user to insert the credentials. It is also not possible to click the overlay away, since it is only possible to do so, when setting the player state to PLAYING. Thus the workaround with temporarily setting pressToPlay to true works for this scenario. In order for the controls to be rendered the pressToPlay state has to be set to false afterwards.
7a435c2
to
967bde6
Compare
I'm using this plugin as a beta tester already and I am very happy with it. I appreciate if you merge this commit into the code. disclaimer: I'm using this feature in my high school but work as an external advisor for Werft22 too. |
Is there anything we can do to help getting this merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing to H5P, and sorry for this taking so long...
Before I test this PR, I would like to see the following changes:
- document.getElementById(id) shouldn't be neccessary, since the reference to the iframe is created by this code (i.e: player)
- contentWindow.postMessage is duplicated many places. Could you please wrap this inside a function?
Thank you very much; I'll check back with @tobiasreischmann so we can do this as soon as possible. @fnoks: If/when you want to test it, you may use the following link to a video: https://www.nanoo.tv/link/v/Moodle |
I think the requested changes have now been committed - @fnoks, can you please check again? |
@fnoks, is there anything we can do to resolve the changes requested? Kind rgards Andreas Trottmann |
Any updates? I would be very happy to see this integrated. |
I am writing on behalf of all teachers who would like to use H5P with nanoo.tv. Could you please complete the code as described above. |
Hi there, we have currently around 40'000 users, mainly teachers, that use our video streaming and online-library tool nanoo.tv More and more customers ask us for H5P. Is there anything you need from our side in order to make this integration happen? We are planning a campaign in october and would be happy to offer this often demanden feature to our customers. |
just to clear the field: nanoo.tv has its user base in Switzerland only, but for that it is the market leader (especially in K12, which is one of the target audience of h5p too). Merge is be very appreciated. |
Hi, I have a similar needs that this one, but I see that this PR hasn't been merged for a while now. |
@fnoks We (https://dlh.zh.ch/) would also support this PR as nanoo.tv is the market leader in Switzerland and is widely used in education. It seems all the changes requested:
have been implemented. Is there anything we can do to speed this up? |
This patch provides an additional video-player, which enables to use h5p for videos provided by the swiss educational platform nanoo.tv.
It would be really nice, if this could be integrated.
Please, let me know, if any changes to the code are necessary, in order to make the integration work.
Cheers,
Tobias