Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to hcaptcha-loader #144

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

CAMOBAP
Copy link
Collaborator

@CAMOBAP CAMOBAP commented Jan 26, 2024

No description provided.

@CAMOBAP CAMOBAP self-assigned this Jan 26, 2024
Copy link

github-actions bot commented Jan 26, 2024

Diffuse report:

OLD: sdk-main.aar
NEW: sdk-pr.aar

 AAR      │ old       │ new       │ diff       
──────────┼───────────┼───────────┼────────────
      jar │  51.7 KiB │  52.7 KiB │     +947 B 
 manifest │     411 B │     411 B │        0 B 
      res │  78.3 KiB │  78.3 KiB │        0 B 
    other │     954 B │     954 B │        0 B 
──────────┼───────────┼───────────┼────────────
    total │ 131.3 KiB │ 304.6 KiB │ +173.3 KiB 

 JAR     │ old │ new │ diff         
─────────┼─────┼─────┼──────────────
 classes │  37 │  37 │   0 (+0 -0)  
 methods │ 507 │ 517 │ +10 (+12 -2) 
  fields │ 162 │ 164 │  +2 (+2 -0)
AAR
 size      │ diff       │ path                           
───────────┼────────────┼────────────────────────────────
 126.2 KiB │ +126.2 KiB │ + assets/hcaptcha/loader.js    
  46.2 KiB │  +46.2 KiB │ + assets/hcaptcha/polyfills.js 
       0 B │        0 B │ + assets/hcaptcha/             
       0 B │        0 B │ + assets/                      
  52.7 KiB │     +947 B │ ∆ classes.jar                  
───────────┼────────────┼────────────────────────────────
   225 KiB │ +173.3 KiB │ (total)
JAR
METHODS:

   old │ new │ diff         
  ─────┼─────┼──────────────
   507 │ 517 │ +10 (+12 -2) 
  
  + com.hcaptcha.sdk.HCaptchaWebViewHelper access_100(HCaptchaWebViewHelper) → HCaptchaConfig
  + com.hcaptcha.sdk.HCaptchaWebViewHelper access_200(HCaptchaWebViewHelper) → HCaptchaWebView
  + com.hcaptcha.sdk.HCaptchaWebViewHelper access_300(HCaptchaWebViewHelper) → IHCaptchaVerifier
  + android.content.Context getAssets() → AssetManager
  + android.content.res.AssetManager open(String) → InputStream
  + android.net.Uri parse(String) → Uri
  + android.view.View getContext() → Context
  + android.webkit.WebResourceResponse <init>(String, String, int, String, Map, InputStream)
  + java.util.Collections singletonMap(Object, Object) → Map
  + java.util.Map get(Object) → Object
  + java.util.Map put(Object, Object) → Object
  + java.util.Objects toString(Object, String) → String
  
  - com.hcaptcha.sdk.HCaptchaWebViewHelper access_100(HCaptchaWebViewHelper) → HCaptchaWebView
  - com.hcaptcha.sdk.HCaptchaWebViewHelper access_200(HCaptchaWebViewHelper) → IHCaptchaVerifier
  

FIELDS:

   old │ new │ diff       
  ─────┼─────┼────────────
   162 │ 164 │ +2 (+2 -0) 
  
  + com.hcaptcha.sdk.BuildConfig LOADER_VERSION: String
  + com.hcaptcha.sdk.HCaptchaWebViewHelper_HCaptchaWebClient assetsCache: Map

Copy link

github-actions bot commented Jan 26, 2024

Benchmark report:

Test name Time ms. (median) Allocations (median)
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerification +336.35 -6
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerificationColdRun +394.48 +106
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleSetup -0.26 +102
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugInfo +10.01 +556
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugSys +54.75 +1
com.hcaptcha.sdk.HCaptchaWebViewHelperTest.EMULATOR_UNLOCKED_benchmarkWebViewLoad +641.99 +85

@e271828-
Copy link
Contributor

e271828- commented Jan 26, 2024

Waiting for next release of loader with less bloated sentry.

@e271828- e271828- marked this pull request as draft January 29, 2024 13:24
@CAMOBAP CAMOBAP requested a review from DSergiu February 29, 2024 21:30
@CAMOBAP CAMOBAP marked this pull request as ready for review February 29, 2024 21:31
Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarCloud

@CAMOBAP CAMOBAP force-pushed the feature/migrate-to-hcaptcha-loader branch from 9b897b9 to 7f421f0 Compare June 26, 2024 20:46
Copy link

sonarcloud bot commented Jul 7, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants