Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [+] pr comment with test summary per spark version #277

Merged
merged 36 commits into from
Oct 3, 2022

Conversation

eruizalo
Copy link
Collaborator

@eruizalo eruizalo commented Sep 1, 2022

Description

This change is trying to get the testing more visible and accessible. Thanks to this we could see the incrementing number of tests across different versions and detect if a test should be somewhere else. This may not be the best solution, but it is a starting point.

Related Issue and dependencies

  • Resolves N/A
  • Depends on N/A

How Has This Been Tested?

From now on we can also see a GITHUB_SUMMARY or each run (go to each run to see it)

If everything is OK

Add PR comment, showing everything is ok and how many tests
PR comment: https://github.com/eruizalo/doric/actions/runs/3152756468
CI: https://github.com/eruizalo/doric/actions/runs/3152678869
image
image

If some tests fail

Add PR comment, showing test failures

image

image

If PR comment workflow fail (because no artifacts found or whatever):

Add a failure comment

@eruizalo eruizalo requested a review from a team as a code owner September 1, 2022 14:58
@github-actions github-actions bot added the CI/CD Continuous integration and continuous delivery label Sep 1, 2022
@eruizalo eruizalo force-pushed the feat/test_summary branch 2 times, most recently from 0cc581a to b233f0b Compare September 1, 2022 15:03
@eruizalo eruizalo marked this pull request as draft September 2, 2022 11:47
@eruizalo eruizalo force-pushed the feat/test_summary branch 4 times, most recently from ac54e1a to 0424a66 Compare September 2, 2022 12:35
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #277 (f3b1011) into main (c0b4ee0) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #277   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files          58       58           
  Lines        1129     1129           
  Branches       13       13           
=======================================
  Hits         1099     1099           
  Misses         30       30           
Flag Coverage Δ
spark-2.4.x 94.86% <ø> (ø)
spark-3.0.x 96.65% <ø> (ø)
spark-3.1.x 97.45% <ø> (ø)
spark-3.2.x 97.45% <ø> (ø)
spark-3.3.x 97.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0b4ee0...f3b1011. Read the comment docs.

@alfonsorr alfonsorr marked this pull request as ready for review September 2, 2022 14:33
@alfonsorr alfonsorr marked this pull request as draft September 2, 2022 14:33
@eruizalo eruizalo marked this pull request as ready for review September 27, 2022 07:01
alfonsorr
alfonsorr previously approved these changes Sep 27, 2022
@eruizalo eruizalo merged commit 338b337 into hablapps:main Oct 3, 2022
@eruizalo eruizalo deleted the feat/test_summary branch October 3, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Continuous integration and continuous delivery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants