Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 3A, 3B, 4 - Daniel Ching #205

Closed
wants to merge 15 commits into from

Conversation

ruiyichi
Copy link

@ruiyichi ruiyichi commented Dec 22, 2023

Developer: Daniel Ching

Closes #110, #134, #168

Pull Request Summary

Blog + Portfolio pages use own MongoDB database, dynamically retrieve individual blogs, fetch comments, contact form

Special Instructions (optional)

Pull Request Checklist

  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit messages follows our guidelines
  • The developer name is specified
  • The summary is completed
  • Ask for a review in communication channels

Screenshots/Screencast

email
https://bootcamp-project-2023-o2gn7rhry-fox-voxs-projects.vercel.app/

Copy link

gitguardian bot commented Dec 22, 2023

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- MongoDB Credentials dd183b7 bootcamp-milestone-2/src/helpers/db.ts View secret
- MongoDB Credentials 1fe6c6a bootcamp-milestone-2/src/helpers/db.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@ruiyichi ruiyichi changed the title Milestone 3A + 3B - Daniel Ching Milestone 3A, 3B, 4 - Daniel Ching Dec 22, 2023
@connorpobrien connorpobrien self-requested a review January 16, 2024 00:36
Copy link

@connorpobrien connorpobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Milestone 3A - Creating The Backend
2 participants