Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 3A, 3B, and (some of) 4 #221

Closed
wants to merge 11 commits into from

Conversation

spaykel
Copy link

@spaykel spaykel commented Dec 23, 2023

Developer: Sammy Paykel

Closes #110, #134, #168

Pull Request Summary

My Milestone 3A pull request is still pending, so I'm adding on some work for 3B and 4 to this pull request here. Milestone 4 is still a work in progress, so I appreciate your understanding as I try to fix up my site. Thanks guys for all the help this quarter with teaching us, and I'll continue working to get my website fully functional soon!

Special Instructions (optional)

Pull Request Checklist

  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit messages follows our guidelines
  • The developer name is specified
  • The summary is completed
  • Ask for a review in communication channels

Screenshots/Screencast

Copy link

gitguardian bot commented Dec 23, 2023

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- MongoDB Credentials 57d25f9 milestone3b/.env View secret
- MongoDB Credentials 7b712ba milestone3a/.env View secret
- MongoDB Credentials 57d25f9 milestone2/.env View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@VasPug
Copy link
Collaborator

VasPug commented Jan 15, 2024

Sounds good. Your code looks great!

@VasPug VasPug closed this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Milestone 3A - Creating The Backend
2 participants