Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 2 #81

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

AceOfRay
Copy link

@AceOfRay AceOfRay commented Nov 5, 2023

Developer: Ray Valenzuela

Closes #{ISSUE NUMBER HERE}

Pull Request Summary

Finished milestone 2. Also ignore the junk on the outside of the folders

Special Instructions (optional)

My first milestone can be found following the submodule found in the repo.

Pull Request Checklist

  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit messages follows our guidelines
  • The developer name is specified
  • The summary is completed
  • Ask for a review in communication channels

Screenshots/Screencast

@AceOfRay AceOfRay changed the title Ace of ray's site Milestone 2 Nov 5, 2023
@hanmosh hanmosh requested review from hanmosh and removed request for hanmosh November 13, 2023 05:22
Copy link

@hanmosh hanmosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ray! Good work so far. Just a couple of things I wanted to point out:

  • I noticed that you had a recipe page that had the same functionality as the blog page. Looks great! I’d recommend also populating your blog page in a similar way. (create a file called blogData.ts and follow the format on the notion). Your milestone 1 is not marked as complete on our end because of the absence of your blog pages. Once you add those, I'll mark it as complete for you.
  • For your Navbar use < Link > tags instead of < a > tags.
  • In the future, make sure that your commits follow the “feat:”, “fix:”, etc format. It helps keep your commits organized and also helps others understand what changes you are making.
  • Also, please include the issue number in your pull request!

Please make the necessary changes and submit again for approval. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants