-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Milestone 2 #81
Open
AceOfRay
wants to merge
11
commits into
hack4impact-calpoly:main
Choose a base branch
from
AceOfRay:AceOfRay'sSite
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Milestone 2 #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanmosh
requested changes
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Ray! Good work so far. Just a couple of things I wanted to point out:
- I noticed that you had a recipe page that had the same functionality as the blog page. Looks great! I’d recommend also populating your blog page in a similar way. (create a file called blogData.ts and follow the format on the notion). Your milestone 1 is not marked as complete on our end because of the absence of your blog pages. Once you add those, I'll mark it as complete for you.
- For your Navbar use < Link > tags instead of < a > tags.
- In the future, make sure that your commits follow the “feat:”, “fix:”, etc format. It helps keep your commits organized and also helps others understand what changes you are making.
- Also, please include the issue number in your pull request!
Please make the necessary changes and submit again for approval. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer: Ray Valenzuela
Closes #{ISSUE NUMBER HERE}
Pull Request Summary
Finished milestone 2. Also ignore the junk on the outside of the folders
Special Instructions (optional)
My first milestone can be found following the submodule found in the repo.
Pull Request Checklist
Screenshots/Screencast