Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Ignore) Milestone 1 #4

Closed
wants to merge 10 commits into from
Closed

Conversation

carboninl
Copy link

@carboninl carboninl commented Oct 16, 2024

Milestone: 1

Developer: Nick Carboni

Closes #1

Pull Request Summary

This is the completed milestone 1 being submitted for review. Added Typescript to dynamically add blog posts to DOM.

Pull Request Checklist

  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit message follows our guidelines
  • The milestone number is specified
  • The developer name is specified
  • The summary is completed

Reviewer Checklist - PULL REQUEST REVIEWER ONLY

IMPORTANT: The rest of the sections in this checklist should only be filled out by authorized pull request reviewers. If you are the individual template contributor, do not fill out the rest of the fields or check the boxes.

NOTE: Milestones can only be completed when all boxes are checked.

  • The code is fully reviewed
  • Meaningful feedback is given
  • Comment that you have reviewed the code
  • This box is checked

@carboninl
Copy link
Author

Missed some of the requirements (didn't realize the last bullet points in the notion were expandable). Will implement these features then retry submission.

@carboninl carboninl closed this Oct 17, 2024
@carboninl carboninl changed the title Milestone 1 Submission (Ignore) Milestone 1 Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Milestone 1 - Adding Typescript
1 participant