Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[176] feat: recipient profiles on driver side #185

Open
wants to merge 5 commits into
base: sprint-refactor
Choose a base branch
from

Conversation

kaseyliu
Copy link
Collaborator

@kaseyliu kaseyliu commented May 25, 2023

Developer: Kasey Liu

Pull Request Summary

Added new tab for recipient profiles on Dashboard page

Pull Request Checklist

(Acutally check off the boxes to make sure you've done everything)

  • Link your issue
  • PR title is in the format [issue #] type: description
  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit messages follows our guidelines
  • Developer name is specified
  • Summary is completed
  • Request a review from your tech leads

AFTER REVIEW

  • Make sure you respond to all of the reviewer's feedback.
  • If they make proposed changes either accept them or respond with questions/clarification.
  • If they make comments either respond, or if you fixed the issue, resolve the conversation

Reviewer Checklist - PULL REQUEST REVIEWER ONLY

IMPORTANT: The rest of the sections in this checklist should only be filled out by authorized pull request reviewers. If you are the individual contributor, do not fill out the rest of the fields or check the boxes.

Reviewer: Full Name

NOTE: Pull requests should only be merged when all boxes are checked.

  • Assign yourself as reviewer if not assigned
  • The reviewer name is specified
  • The code is fully reviewed
  • Meaningful feedback is given
  • Let developer know a review has been made

@kaseyliu kaseyliu linked an issue May 25, 2023 that may be closed by this pull request
5 tasks
@esauerbo esauerbo self-requested a review May 25, 2023 22:33
Copy link
Collaborator

@esauerbo esauerbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Pending merge until after demo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

176 - Recipient Profiles on Driver Side
2 participants