Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Navbar color on /get is inconsistent #2296

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LucasHT22
Copy link
Member

there's other ways to fix:
changing legacy css files;
changing /get css to a style tag inside it;
making /get own css file;
.....
why this solution?
fixes other color inconsistents

fixes #2259

Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sprig ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 9:58pm

Copy link
Contributor

@grymmy grymmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this tested w/ different themes (light/dark/etc?)

@grymmy
Copy link
Contributor

grymmy commented Sep 11, 2024

there's other ways to fix: changing legacy css files; changing /get css to a style tag inside it; making /get own css file; ..... why this solution? fixes other color inconsistents

fixes #2259

In the future, in the description of your PR, start off with what your change is and what it addresses (for instance, linking to an associated github issue). It's cool to follow that up with alternatives you considered, but that should be the meat and potatoes of your description (describing your actual change). For instance, you might say "modified CSS property to be the correct color per issue #blah".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navbar color on /get is inconsistent
2 participants