Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial incubator resources for container build #819

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tylerthome
Copy link
Member

Completes some items from #627

What changes did you make?

  • add Dockerfile definitions for base and app container images to .incubator directory
  • add auxiliary files (e.g. nginx config, entrypoint bash script) to .incubator directory

Rationale behind the changes?

  • prepare for GitHub Action deployment to incubator ECR and ECS

Testing done for these changes

  • deployment to ECR

What did you learn or can share that is new?(optional)

  • Dockerized nginx customization for server blocks (without TLS), in contrast to existing EC2 configuration

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

N/A

Copy link
Member

@paulespinosa paulespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Renaming docker-entrypoint.sh will help avoid confusion. Thank you!

Copy link
Member

@paulespinosa paulespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gunicorn is not a dependency anymore and I can't see where it's being installed. You might be able to get away with running the fastapi run app/main.py --port 8000 command instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants