Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring node labels in-line #1005

Merged
merged 5 commits into from
Aug 3, 2023
Merged

Bring node labels in-line #1005

merged 5 commits into from
Aug 3, 2023

Commits on Aug 2, 2023

  1. docs: Fix comment typo

    Signed-off-by: George Thomas <[email protected]>
    georgefst committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    57b2fc1 View commit details
    Browse the repository at this point in the history
  2. feat: Add optional "inline" mode for displaying nodes

    This uses up less space, and reads nicely (more text-like) for `λ`/`∀`/`Λ` nodes.
    
    We can trigger this mode through the tree/text toggle. This is a slight abuse of this element, and we'll likely revisit this if/when we have more optional display behaviour. On the other hand, this display option is fairly experimental for now, and it may well be that we don't keep both tree styles around in the long run.
    
    Signed-off-by: George Thomas <[email protected]>
    georgefst committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    647c748 View commit details
    Browse the repository at this point in the history
  3. fix: Avoid anti-aliasing issues in "inline"-style nodes

    We had an issue where there were sometimes small visible gaps between the node label and border. These gaps would flicker while zooming in and out. This was seen across multiple browsers.
    
    We fix this by adding extra padding around the label so that it intersects the border, rather than meeting it precisely.
    
    There is a side effect here, which is that labels in term-level nodes are now curved on both sides (I wouldn't have known how to implement this otherwise). But this is arguably an improvement anyway.
    
    Signed-off-by: George Thomas <[email protected]>
    georgefst committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    ddf7881 View commit details
    Browse the repository at this point in the history
  4. chore: Formatting

    Signed-off-by: George Thomas <[email protected]>
    georgefst committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    284a2fa View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. ci: disable pnpm audit step for the time being

    `pnpm audit` is currently complaining about the following GitHub
    security advisories on the `vm2` package:
    
    GHSA-cchq-frgv-rjh5
    GHSA-g644-9gfx-q4q4
    
    We don't use `vm2` directly: it is a (very) transitive dependency of
    `ibm-openapi-validator` via `@orval/core`. The validator is only
    potentially run when we generate our Primer API bindings, and in fact,
    we do not even currently run the validator at all, as it doesn't like
    our OpenAPI spec. Therefore, this advisory isn't relevant to us at
    this time.
    
    Unfortunately, there is currently no way to tell `pnpm audit` to
    ignore GHSA advisories, only CVEs. See relevant discussion in:
    
    https://github.com/orgs/pnpm/discussions/6204
    pnpm/pnpm#6838
    
    Ironically, it seems like it may be possible to use another IBM tool
    to post-process the output of `pnpm audit` and ignore certain issues:
    
    https://github.com/orgs/pnpm/discussions/5229
    
    However, until we have time to look into that, we'll just disable
    `pnpm audit` in order to make forward progress. Note that we are also
    running regular security scans via GitHub's Dependabot and Snyk, so we
    have good security coverage even without the `pnpm audit` step.
    
    Signed-off-by: Drew Hess <[email protected]>
    dhess committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    d2987d0 View commit details
    Browse the repository at this point in the history