Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: show expected and actual type for mismatches #1091

Merged
merged 2 commits into from
Nov 20, 2023
Merged

feat!: show expected and actual type for mismatches #1091

merged 2 commits into from
Nov 20, 2023

Commits on Nov 20, 2023

  1. chore!: bump primer backend, adapt to new selection info api 

    When selecting a non-empty hole, the API now emits information about
both the expected and actual types. We adapt to this change by ignoring
the actual type and just displaying the expected one (this matches the
behaviour with the old backend version). In a subsequent commit we will
show both.

BREAKING CHANGE: the API is different from the previous backend pin. Thus
this version of the frontend cannot talk to the previous version of the
backend and vice versa.

Signed-off-by: Ben Price <[email protected]>
    @brprice
    brprice committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    8fe6dd7 View commit details
    Browse the repository at this point in the history

  2. feat: show expected and actual type for mismatches 

    Mismatches, aka non-empty holes, now show both relevant types. Previously
one would see the expected type in the "Selection info" of the hole,
and the actual type in the info of the body of the hole. Now one sees
both in the info of the hole.

Signed-off-by: Ben Price <[email protected]>
    @brprice
    brprice committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    8edaea6 View commit details
    Browse the repository at this point in the history