-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add edge labels #1097
feat: Add edge labels #1097
Conversation
e1bb793
to
68d716e
Compare
68d716e
to
ac843a2
Compare
ac843a2
to
9ffb0ac
Compare
9ffb0ac
to
b090e44
Compare
Signed-off-by: George Thomas <[email protected]> Signed-off-by: Drew Hess <[email protected]>
b090e44
to
7469794
Compare
This is rebased on
I suspect that lengthening the edges might be tricky, so it might make more sense to punt that until later. |
The code in this commit is maybe a bit rough, but I think it's good enough, and I don't want to hold up this feature any longer. I'm pretty happy with rendering the edge labels as solid-filled "roundels," so I'm keeping that change. I'm going to pass on the edge-lengthening bit for now. |
Ugh, turns out this branch did not include the roundel-style edge labels. I'll commit that change shortly. |
Behaviour is probably what we want, but implementation still a little messy.
We only display labels for
let
nodes for now. Eventually we might want to do more with this, including even labelling every single edge in beginner mode.I had previously thought that labels should be on the outgoing connection rather than the edge itself, out of concern that the latter would look a bit like a node, and as an indication that the number of edges and their names is a property of the parent. But this design, with borderless labels, as iterated on with @dhess last week, actually looks alright.
Closes #24, I suppose.