Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: label styling changes #1144

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

style: label styling changes #1144

wants to merge 3 commits into from

Conversation

dhess
Copy link
Member

@dhess dhess commented Apr 9, 2024

No description provided.

u
we finally see "match" instead of "m" in expert mode

can we remove "always show labels"?

Signed-off-by: George Thomas <[email protected]>
ah, we need to stop setting `width = heigth` if we want "match"

should hiding labels include special nodes (typedefs etc.)

note that `flavorIsSyntax` had become always `false`

Signed-off-by: George Thomas <[email protected]>
@dhess
Copy link
Member Author

dhess commented Apr 9, 2024

This PR captures some styling changes to labels and was intended to be included in #1142, but I broke these commits out, in addition to #1144, in order to separate the functional changes in #1142 from the pure stylistic changes.

The current state of this PR is that it's a WIP.

@dhess dhess added WIP A work in progress, not ready for merging Do not merge Do not merge UX UX issue UI labels Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do not merge Do not merge UI UX UX issue WIP A work in progress, not ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants