-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tailwind.config.js #378
base: main
Are you sure you want to change the base?
Conversation
@@ -12,6 +12,7 @@ module.exports = { | |||
blue: { | |||
primary: "#34375d", | |||
secondary: "#4b5097", | |||
quaternary: "64B0C8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be called tertiary
.
@annedino4 This PR appears to be based on an old PR of George's, so I'm going to rebase it. |
b670772
to
0db4862
Compare
3f32f78
to
0db4862
Compare
On a related note, the secondary red color is now more red than "salmon." I think we chose the more pink-ish red for warnings & holes because it looks less like an error, so what's the thinking in moving towards red? |
We use that colour for tiny text (undo) which is not suitable contract-wise. It is safer and more versatile using a darker colour for warning. How about below? |
It's a good point about the contrast of the "undo" text, but personally I really dislike those brown-ish colors for warnings, especially as they're going to be fairly commonly used. What if, instead, we kept the current warning color since it looks nice as a button/hole color, and instead make the Undo and Redo buttons on the toolbar solid colors like our other buttons? Then we can use white text against the background and everything is fine. It's also more consistent with our other buttons, including the tree/text button that's also on the toolbar. |
Alternatively, there's no reason we can't use |
Hmm, that is unfortunate that the salmon color with white text doesn't pass the check, because I think it would be out of place if it were the only button color without white text. Can we explore some more orange-ish options that pass the test with white text? |
I think I prefer the 2nd row ( |
Added new colours and changed some old colours with the new colourful tree design in mind. See below file for reference: https://www.figma.com/file/w8RpeMkOo63As4k50y4ezt/Primer-Design-Library-22?node-id=0%3A1
Updated blue tertiary & quaternary.
Updated blue tertiary, quaternary and red secondary-hover,
As discussed, changed the red colour pallet.
a20e31d
to
541736f
Compare
I will pick this up and take it over the line. In light of our decision to create a separate high-contrast theme, some of the changes here may not be necessary. |
Added new colours and changed some old colours with the new colourful tree design in mind. See below file for reference:
https://www.figma.com/file/w8RpeMkOo63As4k50y4ezt/Primer-Design-Library-22?node-id=0%3A1