Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree click interaction fixes #834

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Tree click interaction fixes #834

wants to merge 5 commits into from

Commits on Mar 22, 2023

  1. chore: Add type annotation to edgeCommon

    @georgefst
    georgefst committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    bd263d0 View commit details
    Browse the repository at this point in the history

  2. fix: Make edges unfocusable 

    Previously, edges could be clicked and would change colour. For now at least, there are no interactions we perform on edges, so this was potentially confusing.
    @georgefst
    georgefst committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    351896a View commit details
    Browse the repository at this point in the history

  3. fix: Make cursor styles reflect reality 

    This makes it clear that nodes can be clicked on, but not edges, and that only the background can be used for drag-to-pan.

One might hope that ReactFlow would handle this for us, but it doesn't go far enough, perhaps because its main intended use case involves more interactivity, whereas we essentially just use it for rendering.
    @georgefst
    georgefst committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    fb782dc View commit details
    Browse the repository at this point in the history

  4. refactor: Cleaner distinguishing of def-name node in onNodeClick 

    This was made possible by recent changes to make `PrimerNode` a proper discriminated union.
    @georgefst
    georgefst committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    dcde712 View commit details
    Browse the repository at this point in the history

  5. (hack) select node when parent edge is clicked

    @georgefst
    georgefst committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    ec4a88b View commit details
    Browse the repository at this point in the history