Skip to content

Commit

Permalink
perf: strictify Meta's ID field (#1110)
Browse files Browse the repository at this point in the history
  • Loading branch information
@brprice
brprice authored Aug 15, 2023
2 parents e3f2d18 + 305560d commit 93ece25
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion primer/src/Primer/Core/Meta.hs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ newtype ID = ID {unID :: Int}
deriving newtype (ToJSONKey, FromJSONKey)
deriving anyclass (NFData)

data Meta a = Meta ID a (Maybe Value)
data Meta a = Meta !ID a (Maybe Value)
deriving stock (Generic, Eq, Ord, Show, Read, Data, Functor)
deriving (FromJSON, ToJSON) via PrimerJSON (Meta a)
deriving anyclass (NFData)
Expand Down

1 comment on commit 93ece25

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Primer benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 93ece25 Previous: e3f2d18 Ratio
typecheck/mapOddPrim 1: outlier variance 0.10634868277342593 outlier variance 0.012193263222069838 outlier variance 8.72

This comment was automatically generated by workflow using github-action-benchmark.

CC: @dhess

Please sign in to comment.