Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop primer-rel8 and PostgreSQL support #1102

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Conversation

dhess
Copy link
Member

@dhess dhess commented Jul 31, 2023

For rationale, see:

#1101

Closes #1101.

@dhess
Copy link
Member Author

dhess commented Jul 31, 2023

Note that this isn't a done deal, just a prospective PR to see how much code etc. we could delete if we dropped support for PostgreSQL.

For rationale, see:

#1101

Signed-off-by: Drew Hess <[email protected]>
@dhess dhess added Do not merge Do not merge blocked/need-info ❌ Blocked, need more information labels Jul 31, 2023
@dhess
Copy link
Member Author

dhess commented Aug 1, 2023

We've decided to drop PostgreSQL support, at least for the time being, so I will merge this PR.

Does anyone object if I merge it now, or should I wait for the other (fairly major) PRs that are currently nearly ready to merge? I don't want to cause any nasty rebases, but I don't expect there will be many, if any, conflicts.

@dhess dhess requested a review from a team August 1, 2023 16:08
Copy link
Contributor

@georgefst georgefst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look like it should have any non-trivial conflicts with other in-progress work.

@brprice
Copy link
Contributor

brprice commented Aug 1, 2023

This doesn't look like it should have any non-trivial conflicts with other in-progress work.

Agree. Let's merge it

@dhess dhess added this pull request to the merge queue Aug 1, 2023
@dhess dhess removed Do not merge Do not merge blocked/need-info ❌ Blocked, need more information labels Aug 1, 2023
Merged via the queue into main with commit 2234d98 Aug 1, 2023
2 checks passed
@dhess dhess deleted the dhess/drop-postgres branch August 1, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for PostgreSQL?
3 participants