Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: strictify Meta's ID field #1110

Merged
merged 1 commit into from
Aug 15, 2023
+1 −1
Merged

perf: strictify Meta's ID field #1110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion primer/src/Primer/Core/Meta.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ newtype ID = ID {unID :: Int}
deriving newtype (ToJSONKey, FromJSONKey)
deriving anyclass (NFData)

data Meta a = Meta ID a (Maybe Value)
data Meta a = Meta !ID a (Maybe Value)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could someone independently confirm some time&space measurements for this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just merge this -- easy enough to revert, and hopefully our benchmark suite will reproduce.

deriving stock (Generic, Eq, Ord, Show, Read, Data, Functor)
deriving (FromJSON, ToJSON) via PrimerJSON (Meta a)
deriving anyclass (NFData)
Expand Down