Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate to mtl-2.3.1 #760

Closed
wants to merge 1 commit into from
Closed

chore: Migrate to mtl-2.3.1 #760

wants to merge 1 commit into from

Conversation

dhess
Copy link
Member

@dhess dhess commented Nov 3, 2022

@dhess
Copy link
Member Author

dhess commented Nov 3, 2022

Not yet working due to ecosystem issues; e.g., #665 (comment)

@brprice
Copy link
Contributor

brprice commented Feb 6, 2023

I pushed a commit exposing mtl's modifyError from Foreword, which should fix the primer compilation issue. (Alternative approach: import Control.Monad.Except where needed -- I think only in Primer.App) (Edit: this (is planned to be) is squashed into the first commit)

@dhess
Copy link
Member Author

dhess commented Feb 6, 2023

Thanks. There is still some community breakage preventing this from building, but it sounds like it may be fixed shortly.

@brprice
Copy link
Contributor

brprice commented Feb 6, 2023

Yes, we now fail the build because of happy, rather than our own code. I don't really understand why we were failing on primer before -- was happy not being rebuilt first? Oh, previously we failed on primer:lib:primer, but now that succeeds, and we fail on primer:lib:primer-testlib

@dhess dhess added the Do not merge Do not merge label Feb 6, 2023
@@ -1,5 +1,6 @@
module Foreword (
module Protolude,
modifyError,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhess : this should probably just be squashed into the initial commit

@dhess
Copy link
Member Author

dhess commented Feb 6, 2023

Happy's been updated on Hackage, so hopefully after the next haskell.nix Hackage update, this will finally build.

@brprice
Copy link
Contributor

brprice commented Apr 11, 2023

Current ecosystem incompatibilities:

I believe this is all

@dhess
Copy link
Member Author

dhess commented Aug 23, 2023

Via #1113, we're now on mtl-2.3.1 (finally).

@dhess dhess closed this Aug 23, 2023
@dhess dhess deleted the dhess/mtl-2.3.1 branch August 23, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants